fix: prevent setRawValue to convert 0 to empty string #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be worth adding a test for this? |
dogle-scottlogic
previously approved these changes
Jul 25, 2018
|
@ryanggrey I just added a single unit test for this use case. |
oriondean
reviewed
Aug 6, 2018
| value = helpers.rawToFormatted(val, this.options); | ||
| } else if (typeof val === 'string') { | ||
| value = val; | ||
| } else if (!val) { |
There was a problem hiding this comment.
Do we need this else-if clause if the clause above will fire instead? (empty string is typeof string, setting value to '')
There was a problem hiding this comment.
it is my understanding setRawValue is a public method, and can be called with undefined or null
ryanggrey
approved these changes
Aug 6, 2018
oriondean
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113