Browserstack ci #105
Merged
Browserstack ci #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 14, 2017 13:16
These can only be decrypted by the private key for the travis ScottLogic/finput repo
The tests will only run when not a PR. See link in patch for reasoning. This is ok as the tests will run once a merge commit is made to master and if it fails semantic-release will not run.
Also add `npm test:ci` which does the same but assumes webdriver already running.
oriondean
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to test this as part of a CI triggered build yet. It needs to be merged to master before that can happen. Note that as per Travis docs we only run the browserstack tests on new
mastercommits (not on PRs).We also just setup config for chrome. We can add more browsers once we have this up and running with CI.