Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUU52: Add E2E tests to CI #66

Merged
merged 3 commits into from
Oct 10, 2023
Merged

VUU52: Add E2E tests to CI #66

merged 3 commits into from
Oct 10, 2023

Conversation

pling-scottlogic
Copy link

Description

Adds a job to the Test stage of the CI/CD pipeline to run Cypress end-to-end tests whenever a PR is raised. Tests are set to run in Chrome and Edge until the Firefox bug is fixed (#30).

Change List

  • Add a job to test-ui.yml to run Cypress E2E tests
  • Fix screenshot test:
    • Change selector for save layout panel
    • Update SHELL_WITH_NEW_THEME_URL constant to match changes to the NewTheme example
    • Point Cypress config to the correct index HTML file location

Closes #52

@pling-scottlogic pling-scottlogic self-assigned this Oct 4, 2023
@pling-scottlogic pling-scottlogic marked this pull request as draft October 4, 2023 16:26
Copy link

@cfisher-scottlogic cfisher-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think it could be worth exploring screenshots for failing tests (if this doesn't happen automatically?) So if a test fails, you get a screenshot of the page to see what's going on which helps debug things (how far did it get, what can the user see, etc). I don't think it's essential because we can just do that locally if this action fails, but if it's not a difficult thing to achieve it might be worth it.

@pling-scottlogic pling-scottlogic merged commit dfacb9c into main Oct 10, 2023
7 checks passed
@pling-scottlogic pling-scottlogic deleted the VUU52-cypressAction branch October 10, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress to run in pipeline
3 participants