Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage layout persistence via interface #40

Closed
wants to merge 25 commits into from
Closed

Manage layout persistence via interface #40

wants to merge 25 commits into from

Conversation

pling-scottlogic
Copy link

Description

Refactors the layout persistence mechanism to work through an interface. We are currently saving layouts to the browser's local storage, but these changes will allow us to easily introduce other methods of persistence, such as a remote database.

Change List

  • Add LayoutPersistenceManager interface
  • Implement new interface with LocalLayoutPersistenceManager
  • Redirect useLayoutManagement hook to make use of new interface
  • Remove props from Dialog (in NewTheme) and LeftNav (fixes from previous rebase)
  • Pass persistence manager in from NewTheme

Notes

  • We should only need to load metadata when browsing layouts, but this change will probably make more sense after doing the JSON refactor in Refactor layout JSON structure #26.
  • Target branch is currently set to the one created recently to merge into the Finos fork. We may need to sync the layout-management-feature and change the target branch here.

Closes #20

@pling-scottlogic pling-scottlogic self-assigned this Sep 12, 2023
@cfisher-scottlogic cfisher-scottlogic linked an issue Sep 13, 2023 that may be closed by this pull request
Create service for persisting layouts #20
Closed
@cfisher-scottlogic cfisher-scottlogic mentioned this pull request Sep 13, 2023
Closed
cfisher-scottlogic
cfisher-scottlogic requested changes Sep 13, 2023
View reviewed changes
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LocalLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-layout/src/layout-persistence/LocalLayoutPersistenceManager.ts Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx Outdated Show resolved Hide resolved
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx Outdated Show resolved Hide resolved
vferraro-scottlogic

This comment was marked as resolved.

Sign in to view

@pling-scottlogic pling-scottlogic mentioned this pull request Sep 21, 2023
Closed
@pling-scottlogic pling-scottlogic mentioned this pull request Sep 21, 2023
Merged
@pling-scottlogic
Copy link
Author

Replaced by #55, with appropriate target branch.

@cfisher-scottlogic cfisher-scottlogic deleted the feature/layout-management/VUU20-layoutPersistence branch October 16, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfisher-scottlogic cfisher-scottlogic cfisher-scottlogic approved these changes

@vferraro-scottlogic vferraro-scottlogic vferraro-scottlogic approved these changes

Assignees

@pling-scottlogic pling-scottlogic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create service for persisting layouts
3 participants
@pling-scottlogic @vferraro-scottlogic @cfisher-scottlogic