-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVUU-69: Display toast on layout load/save #115
Conversation
<ShellWithNewTheme /> | ||
</LayoutManagementProvider> | ||
<NotificationsProvider> | ||
<LayoutManagementProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do this for sample app as well? (vuu-ui/sample-apps/app-vuu-example/index.tsx)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments
vuu-ui/packages/vuu-shell/src/layout-management/useLayoutManager.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a case for when a user's layout fails to load? It's obvious that it's loaded successfully because you can see it. Is it obvious that it hasn't loaded successfully if you don't see it? Probably...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done: 7210e13 |
41ed7c7
to
7ded833
Compare
7ded833
to
73f6dfb
Compare
Merged into Finos main under finos#1004 |
Description
Display toast notifications for all relevant scenarios pertaining to layout management.
Change List
ShellWithNewThemeAndLayoutManagement
Showcase example withNotificationsProvider
notify
fromuseNotifications
in the following instances:Testing
Manually tested on the
ShellWithNewThemeAndLayoutManagement
Showcase example by configuring the app to use remote layout management:Evidence
Success toast displayed after saving a layout:
Error toast displayed after shutting down the layout server and refreshing the app: