Tidy package and type issues (finos#914)

* fix package references, type issues

* add typescript config for correct auto import resolution

vuu-ui/global.d.ts

@@ -0,0 +1,3 @@
+declare module "@thomaschaplin/isin-generator" {
+  export const isinGenerator = () => undefined;
+}

vuu-ui/packages/vuu-codemirror/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-data-ag-grid/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-data-react/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-data-types/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-data/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-datagrid-types/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-datagrid/src/ColumnBearer.tsx

@@ -17,8 +17,8 @@ import "./column-bearer.css";
 import { GridModelType } from "./grid-model";
 import { ColumnDragState, dragPhase } from "./gridTypes";
 import { buildColumnMap } from "@finos/vuu-utils";
-import { KeyedColumnDescriptor } from "packages/vuu-datagrid-types";
-import { DataSourceRow } from "packages/vuu-data-types";
+import { KeyedColumnDescriptor } from "@finos/vuu-datagrid-types";
+import { DataSourceRow } from "@finos/vuu-data-types";
 
 const LEFT = "left";
 const RIGHT = "right";

vuu-ui/packages/vuu-datagrid/src/cell-renderers/progress-cell.tsx

@@ -5,7 +5,7 @@ import React from "react";
 import { isTypeDescriptor } from "@finos/vuu-utils";
 import { GridCellProps } from "../grid-cells";
 import "./progress-cell.css";
-import { ColumnTypeRenderer } from "packages/vuu-datagrid-types";
+import { ColumnTypeRenderer } from "@finos/vuu-datagrid-types";
 
 const ProgressCell = React.memo(function ProgressCell({
   column,

vuu-ui/packages/vuu-datagrid/src/context-menu/build-context-menu-descriptors.ts

@@ -4,7 +4,7 @@ import {
   ContextMenuGroupItemDescriptor,
   ContextMenuItemDescriptor,
   MenuBuilder,
-} from "packages/vuu-data-types";
+} from "@finos/vuu-data-types";
 import {
   VuuAggregation,
   VuuGroupBy,

vuu-ui/packages/vuu-datagrid/src/grid-cells/HeaderCell.tsx

@@ -14,7 +14,7 @@ import { SortIndicator, sortStatus } from "./sort-indicator";
 import { useCellResize } from "./useCellResize";
 
 import "./HeaderCell.css";
-import { DataSourceFilter } from "packages/vuu-data-types";
+import { DataSourceFilter } from "@finos/vuu-data-types";
 
 const classBase = "hwHeaderCell";
 const NO_AGGREGATION = { aggType: -1 };

vuu-ui/packages/vuu-datagrid/src/grid-cells/filter-indicator.tsx

@@ -5,7 +5,7 @@ import cx from "classnames";
 import { HTMLAttributes, useCallback, useMemo } from "react";
 
 import "./filter-indicator.css";
-import { KeyedColumnDescriptor } from "packages/vuu-datagrid-types";
+import { KeyedColumnDescriptor } from "@finos/vuu-datagrid-types";
 
 export const Direction = {
   ASC: "asc",

vuu-ui/packages/vuu-datagrid/src/grid-context.tsx

@@ -14,7 +14,7 @@ import {
   GridAction,
   KeyedColumnDescriptor,
 } from "@finos/vuu-datagrid-types";
-import { DataSourceFilter } from "packages/vuu-data-types";
+import { DataSourceFilter } from "@finos/vuu-data-types";
 
 export interface GridActionGroup {
   type: "group";

vuu-ui/packages/vuu-datagrid/src/grid-hooks/use-data-source.ts

@@ -7,7 +7,7 @@ import {
   toColumnDescriptor,
   WindowRange,
 } from "@finos/vuu-utils";
-import { DataSourceRow } from "packages/vuu-data-types";
+import { DataSourceRow } from "@finos/vuu-data-types";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { useGridContext } from "../grid-context";
 import { GridModelType } from "../grid-model/gridModelTypes";

vuu-ui/packages/vuu-datagrid/src/grid-hooks/useGridActionDispatcher.ts

@@ -3,7 +3,7 @@ import {
   DataSourceAction,
   GridAction,
   ScrollAction,
-} from "packages/vuu-datagrid-types";
+} from "@finos/vuu-datagrid-types";
 import { useCallback } from "react";
 import { GridActionSelection, GridModelDispatch } from "../grid-context";
 

vuu-ui/packages/vuu-datagrid/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-datatable/src/json-table/JsonTable.tsx

@@ -7,9 +7,9 @@ import { TableConfig } from "@finos/vuu-datagrid-types";
 
 export interface JsonTableProps
   extends Omit<TableProps, "config" | "dataSource"> {
-  config: Pick<
+  config?: Pick<
     TableConfig,
-    "columns" | "columnSeparators" | "rowSeparators" | "zebraStripes"
+    "columnSeparators" | "rowSeparators" | "zebraStripes"
   >;
   source: JsonData | undefined;
 }
@@ -20,7 +20,7 @@ export const JsonTable = ({
   ...tableProps
 }: JsonTableProps) => {
   const [dataSource, tableConfig] = useMemo<
-    [JsonDataSource, JsonTableProps["config"]]
+    [JsonDataSource, TableConfig]
   >(() => {
     const ds = new JsonDataSource({
       data: source,

vuu-ui/packages/vuu-datatable/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-filter-parser/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-filter-types/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-filters/src/filter-bar/useFilters.ts

@@ -1,5 +1,5 @@
 import { useControlled } from "@finos/vuu-ui-controls";
-import { Filter } from "packages/vuu-filter-types";
+import { Filter } from "@finos/vuu-filter-types";
 import { useCallback } from "react";
 
 export interface FiltersHookProps {

vuu-ui/packages/vuu-filters/src/filter-builder-menu/FilterBuilderMenu.tsx

@@ -1,5 +1,5 @@
 import { ContextMenuProps } from "@finos/vuu-popups";
-import { MenuActionHandler } from "packages/vuu-data-types";
+import { MenuActionHandler } from "@finos/vuu-data-types";
 import { ReactElement, useCallback, useRef } from "react";
 import { PopupComponent as Popup, Portal } from "@finos/vuu-popups";
 import { List, ListItem } from "@finos/vuu-ui-controls";

vuu-ui/packages/vuu-filters/src/filter-clause/useFilterClauseEditor.ts

@@ -15,7 +15,7 @@ import {
   useRef,
   useState,
 } from "react";
-import { SingleSelectionHandler } from "packages/vuu-ui-controls/src";
+import { SingleSelectionHandler } from "@finos/vuu-ui-controls/src";
 
 const cursorAtTextStart = (input: HTMLInputElement) =>
   input.selectionStart === 0;

vuu-ui/packages/vuu-filters/src/filter-pill/FilterPill.tsx

@@ -3,7 +3,7 @@ import { Filter } from "@finos/vuu-filter-types";
 import { EditableLabel, EditableLabelProps } from "@finos/vuu-ui-controls";
 import { filterAsQuery, isMultiClauseFilter } from "@finos/vuu-utils";
 import cx from "classnames";
-import { PopupCloseCallback } from "packages/vuu-popups/src";
+import { PopupCloseCallback } from "@finos/vuu-popups/src";
 import { HTMLAttributes, useCallback, useRef } from "react";
 import { FilterPillMenu } from "../filter-pill-menu";
 import { filterClauses } from "../filter-utils";

vuu-ui/packages/vuu-filters/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-layout/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-popups/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-protocol-types/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-shell/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-table-extras/src/column-expression-panel/useColumnExpression.ts

@@ -1,4 +1,4 @@
-import { ColumnDescriptor } from "packages/vuu-datagrid-types";
+import { ColumnDescriptor } from "@finos/vuu-datagrid-types";
 import {
   getCalculatedColumnDetails,
   setCalculatedColumnExpression,

vuu-ui/packages/vuu-table-extras/src/column-formatting-settings/NumericFormattingSettings.tsx

@@ -1,6 +1,6 @@
 import { FormField, FormFieldLabel, Input } from "@salt-ds/core";
 import { Switch } from "@salt-ds/lab";
-import { ColumnDescriptor, TypeFormatting } from "packages/vuu-datagrid-types";
+import { ColumnDescriptor, TypeFormatting } from "@finos/vuu-datagrid-types";
 import { getTypeSettingsFromColumn } from "@finos/vuu-utils";
 import {
   ChangeEvent,

vuu-ui/packages/vuu-table-extras/src/column-list/ColumnList.tsx

@@ -7,7 +7,7 @@ import {
 import { Checkbox } from "@salt-ds/core";
 import { Switch } from "@salt-ds/lab";
 import cx from "classnames";
-import { ColumnDescriptor } from "packages/vuu-datagrid-types";
+import { ColumnDescriptor } from "@finos/vuu-datagrid-types";
 import { HTMLAttributes, SyntheticEvent, useCallback } from "react";
 import { ColumnItem } from "../table-settings";
 

vuu-ui/packages/vuu-table-extras/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-table/src/table-next/column-header-pill/ColumnHeaderPill.tsx

@@ -1,5 +1,5 @@
 import cx from "classnames";
-import { KeyedColumnDescriptor } from "packages/vuu-datagrid-types";
+import { KeyedColumnDescriptor } from "@finos/vuu-datagrid-types";
 import { HTMLAttributes, MouseEvent, useCallback } from "react";
 
 import "./ColumnHeaderPill.css";

vuu-ui/packages/vuu-table/src/table-next/column-header-pill/GroupColumnPill.tsx

@@ -1,4 +1,4 @@
-import { KeyedColumnDescriptor } from "packages/vuu-datagrid-types";
+import { KeyedColumnDescriptor } from "@finos/vuu-datagrid-types";
 import { ColumnHeaderPill, ColumnHeaderPillProps } from "./ColumnHeaderPill";
 
 import "./GroupColumnPill.css";

vuu-ui/packages/vuu-table/src/table-next/table-cell/TableCell.tsx

@@ -1,6 +1,6 @@
 import { TableCellProps } from "@finos/vuu-datagrid-types";
 import { metadataKeys } from "@finos/vuu-utils";
-import { VuuColumnDataType } from "packages/vuu-protocol-types";
+import { VuuColumnDataType } from "@finos/vuu-protocol-types";
 import { MouseEventHandler, useCallback } from "react";
 import { useCell } from "../useCell";
 

vuu-ui/packages/vuu-table/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-ui-controls/src/drag-drop/useDragDisplacers.ts

@@ -1,11 +1,11 @@
+import type { orientationType } from "@finos/vuu-utils";
 import { useCallback, useMemo, useRef } from "react";
+import { Direction } from "./dragDropTypesNext";
+import { createDragSpacer as createDragDisplacer } from "./Draggable";
 import {
   MeasuredDropTarget,
   mutateDropTargetsSwitchDropTargetPosition,
 } from "./drop-target-utils";
-import { createDragSpacer as createDragDisplacer } from "./Draggable";
-import { Direction } from "./dragDropTypesNext";
-import { orientationType } from "packages/vuu-utils/src";
 
 export type DragDisplacersHookResult = {
   displaceItem: (

vuu-ui/packages/vuu-ui-controls/src/dropdown/dropdownTypes.ts

@@ -1,4 +1,4 @@
-import { PopupComponentProps, PopupPlacement } from "packages/vuu-popups/src";
+import type { PopupComponentProps, PopupPlacement } from "@finos/vuu-popups";
 import {
   HTMLAttributes,
   KeyboardEvent,

vuu-ui/packages/vuu-ui-controls/src/instrument-picker/useDataSource.ts

@@ -1,7 +1,7 @@
 //TODO stansardise this
 
 import { DataSource, SubscribeCallback } from "@finos/vuu-data";
-import { DataSourceRow } from "packages/vuu-data-types";
+import { DataSourceRow } from "@finos/vuu-data-types";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { MovingWindow } from "./moving-window";
 export interface DataSourceHookProps {

vuu-ui/packages/vuu-ui-controls/src/instrument-search/useDataSource.ts

@@ -1,7 +1,7 @@
 //TODO stansardise this
 
 import { DataSource, SubscribeCallback } from "@finos/vuu-data";
-import { DataSourceRow } from "packages/vuu-data-types";
+import { DataSourceRow } from "@finos/vuu-data-types";
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { MovingWindow } from "./moving-window";
 export interface DataSourceHookProps {

vuu-ui/packages/vuu-ui-controls/src/tabstrip/Tab.tsx

@@ -1,7 +1,7 @@
 // TODO close button needs to be a button. Hence tab needs to include 2 buttons
 import { useForkRef } from "@salt-ds/core";
 import cx from "classnames";
-import { MenuActionHandler } from "packages/vuu-data-types";
+import { MenuActionHandler } from "@finos/vuu-data-types";
 import {
   FocusEvent,
   ForwardedRef,

vuu-ui/packages/vuu-ui-controls/src/tabstrip/TabMenuOptions.ts

@@ -1,4 +1,4 @@
-import { ContextMenuItemDescriptor } from "packages/vuu-data-types";
+import { ContextMenuItemDescriptor } from "@finos/vuu-data-types";
 
 export type MenuOptions = { [key: string]: unknown };
 

vuu-ui/packages/vuu-ui-controls/src/tabstrip/TabsTypes.ts

@@ -8,7 +8,7 @@ import type {
 import { orientationType } from "@finos/vuu-utils";
 
 import type { EditableLabelProps } from "../editable-label";
-import type { MenuActionHandler } from "packages/vuu-data-types";
+import type { MenuActionHandler } from "@finos/vuu-data-types";
 
 export type ExitEditModeHandler = (
   originalValue: string,

vuu-ui/packages/vuu-ui-controls/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/packages/vuu-utils/tsconfig.json

@@ -0,0 +1,6 @@
+{
+"extends": "../../tsconfig.json",
+"compilerOptions":{
+    "composite": true
+},
+}

vuu-ui/sample-apps/app-vuu-example/src/App.tsx

@@ -19,7 +19,7 @@ import { getFormConfig } from "./session-editing";
 import "./App.css";
 // Because we do not render the AppSidePanel directly, the css will not be included in bundle.
 import "./app-sidepanel/AppSidePanel.css";
-import { VuuTable } from "packages/vuu-protocol-types";
+import { VuuTable } from "@finos/vuu-protocol-types";
 
 const defaultWebsocketUrl = `wss://${location.hostname}:8090/websocket`;
 const { websocketUrl: serverUrl = defaultWebsocketUrl, features } =

vuu-ui/sample-apps/feature-basket-trading/src/basket-selector/BasketSelector.tsx

@@ -1,6 +1,5 @@
 import { PriceTicker } from "@finos/vuu-ui-controls";
 import { Button } from "@salt-ds/core";
-// import { VuuDataRow } from "packages/vuu-protocol-types";
 import { DataSource, SubscribeCallback } from "@finos/vuu-data";
 import { useId } from "@finos/vuu-layout";
 import { PopupComponent as Popup, Portal } from "@finos/vuu-popups";

vuu-ui/sample-apps/feature-basket-trading/src/basket-toolbar/BasketToolbar.tsx

@@ -6,7 +6,7 @@ import { BasketStatus } from "../VuuBasketTradingFeature";
 import { BasketMenu } from "./BasketMenu";
 
 import "./BasketToolbar.css";
-import { MenuActionHandler } from "packages/vuu-data-types";
+import { MenuActionHandler } from "@finos/vuu-data-types";
 
 const classBase = "vuuBasketToolbar";