Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

146: Investigate missing avatar issue #276

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

dogle-scottlogic
Copy link
Contributor

@dogle-scottlogic dogle-scottlogic commented Nov 18, 2024

Fix for broken avatar link when a contributor has no image. Addresses issue #146

@dogle-scottlogic dogle-scottlogic marked this pull request as ready for review November 18, 2024 14:40
@dogle-scottlogic dogle-scottlogic marked this pull request as draft November 18, 2024 14:44
@dogle-scottlogic dogle-scottlogic changed the title Not for merge: Investigate missing avatar issue 146: Investigate missing avatar issue Nov 18, 2024
This reverts commit 557e014.
(cherry picked from commit a021f7d)
@dogle-scottlogic dogle-scottlogic marked this pull request as ready for review November 18, 2024 16:04
@chriswilty
Copy link
Member

Do we have an example, e.g. before/after screenshots or a link to a broken article?

@dogle-scottlogic
Copy link
Contributor Author

Do we have an example, e.g. before/after screenshots or a link to a broken article?

😢 - never thought to take a screen shot like a muppet! I think I have something on a branch - let me look

@dogle-scottlogic
Copy link
Contributor Author

Before:
before

After:
after

After (with image):
after-pic

Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌

@chriswilty chriswilty merged commit 2762aad into ScottLogic:gh-pages Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants