-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 253: Fix linting #274
Issue 253: Fix linting #274
Conversation
As far as I can see the accessibility job is failing due to the number of files changed - although the feedback isn't super helpful |
c28305e
to
9cd7723
Compare
There are a lot of whitespace changes, moving summary lines onto a single line. Surely it's not the linter does that? It is making this PR far larger than it needs to be. Also, I'm not convinced Siteleaf adds author as category, as my first post from 9th May was done in siteleaf and is not in the change list. |
This was a side effect of the method I used to remove the author. I've tried a different approach which seems to preserve the formatting of other fields |
_posts/2023-10-26-conscientious-computing-facing-into-big-tech-challenges.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not checked every single file, but I have noted that most are single-line removals which makes sens. The linter script also seems fine.
Don't worry about the pa11y error, we're not changing any actual post content so can ignore it.
Fix the linting, addressed issue #253 :