Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 253: Fix linting #274

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

dogle-scottlogic
Copy link
Contributor

@dogle-scottlogic dogle-scottlogic commented Nov 18, 2024

Fix the linting, addressed issue #253 :

  • Update path matching to match all posts correctly
  • Remove author from category (Note: this seems to be something siteleaf adds so might need to look at that)
  • Allow up to 3 categories to be specified
  • Make 130 char summary a soft (WARN) min
  • Fix unknown category issues

@dogle-scottlogic dogle-scottlogic marked this pull request as ready for review November 18, 2024 14:09
@dogle-scottlogic
Copy link
Contributor Author

As far as I can see the accessibility job is failing due to the number of files changed - although the feedback isn't super helpful

@chriswilty
Copy link
Member

chriswilty commented Nov 19, 2024

There are a lot of whitespace changes, moving summary lines onto a single line. Surely it's not the linter does that? It is making this PR far larger than it needs to be.

Also, I'm not convinced Siteleaf adds author as category, as my first post from 9th May was done in siteleaf and is not in the change list.

@dogle-scottlogic
Copy link
Contributor Author

This was a side effect of the method I used to remove the author. I've tried a different approach which seems to preserve the formatting of other fields

Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not checked every single file, but I have noted that most are single-line removals which makes sens. The linter script also seems fine.

Don't worry about the pa11y error, we're not changing any actual post content so can ignore it.

@chriswilty chriswilty merged commit 3ee001d into ScottLogic:gh-pages Nov 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants