-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich Rogers author page #267
Conversation
Adding folder for rrogers
_data/authors.yml
Outdated
rrogers: | ||
name: "Rich Rogers" | ||
twitter-handle: richrtesting | ||
author-summary: "<p>I am the Testing Capability Lead for Scott Logic. I have been involved in Testing and software delivery for 25 years, working for organisations in the UK and Australia.</p>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think 'testing' needs capitalisation in 'I have been involved in Testing'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 1 comment regarding the twitter-url but other than that all looks fine as far as I can tell.
_data/authors.yml
Outdated
@@ -784,6 +785,11 @@ authors: | |||
author-summary: "<p>I'm a software developer at Scott Logic, Edinburgh. I joined in August 2017 after four years studying Computer Science and Mathematics at the University of Edinburgh.</p>" | |||
twitter-url: "https://twitter.com/trrhodes" | |||
picture: picture.jpg | |||
rrogers: | |||
name: "Rich Rogers" | |||
twitter-handle: richrtesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick look at other entries also specifiy a twitter-url. Do you want to add that as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may just remove the twitter handle actually.
Please add a direct link to your post here:
Added authors page only
Have you (please tick each box to show completion): N/A
npm install
followed bynpx mdspell "**/{FILE_NAME}.md" --en-gb -a -n -x -t
if that's your thing)Posts are reviewed / approved by your Regional Tech Lead.