Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Rogers author page #267

Merged
merged 15 commits into from
Nov 1, 2024
Merged

Rich Rogers author page #267

merged 15 commits into from
Nov 1, 2024

Conversation

slrrogers
Copy link
Contributor

Please add a direct link to your post here:

Added authors page only

Have you (please tick each box to show completion): N/A

  • Added your blog post to a single category?
  • Added a brief summary for your post? Summaries should be roughly two sentences in length and give potential readers a good idea of the contents of your post.
  • Checked that the build passes?
  • Checked your spelling (you can use npm install followed by npx mdspell "**/{FILE_NAME}.md" --en-gb -a -n -x -t if that's your thing)
  • Ensured that your author profile contains a profile image, and a brief description of yourself? (make it more interesting than just your job title!)
  • Optimised any images in your post? They should be less than 100KBytes as a general guide.

Posts are reviewed / approved by your Regional Tech Lead.

rrogers:
name: "Rich Rogers"
twitter-handle: richrtesting
author-summary: "<p>I am the Testing Capability Lead for Scott Logic. I have been involved in Testing and software delivery for 25 years, working for organisations in the UK and Australia.</p>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think 'testing' needs capitalisation in 'I have been involved in Testing'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot :)

Copy link
Contributor

@sshiells-scottlogic sshiells-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 comment regarding the twitter-url but other than that all looks fine as far as I can tell.

@@ -784,6 +785,11 @@ authors:
author-summary: "<p>I'm a software developer at Scott Logic, Edinburgh. I joined in August 2017 after four years studying Computer Science and Mathematics at the University of Edinburgh.</p>"
twitter-url: "https://twitter.com/trrhodes"
picture: picture.jpg
rrogers:
name: "Rich Rogers"
twitter-handle: richrtesting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look at other entries also specifiy a twitter-url. Do you want to add that as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may just remove the twitter handle actually.

@chriswilty chriswilty merged commit ac9f8b0 into ScottLogic:gh-pages Nov 1, 2024
1 check passed
chriswilty pushed a commit to chriswilty/sl-blog that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants