fix: docker build and run corrections #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Obvs I'd love someone to try this out 🧐 If you already have a |
Also fixed for Git bash on Windows
chriswilty
force-pushed
the
257-docker-fix
branch
from
0157538 to
f1c7309
Compare
mgriffin-scottlogic
approved these changes
Oct 21, 2024
jstrong-scottlogic
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with gem 'ffi' brought in via gem github-pages:
ffi/ffi#1103
I've applied the fix in our Gemfile, with a clarifying comment.
I also fixed a path-related problem when using Git bash on Windows, as Docker does not recognise Git bash's linuxified drive paths, such as
/c/dev/hello-world. This must be translated toC:/dev/hello-world. Now both build and serve work in Git bash on Windows machines 🥳resolves #257