Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ux changes #1398

Closed
wants to merge 6 commits into from
Closed

Minor ux changes #1398

wants to merge 6 commits into from

Conversation

Johnston97
Copy link
Contributor

@Johnston97 Johnston97 commented Nov 21, 2019

Copy link
Contributor

@swoods-scottlogic swoods-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works how i would expect. Happy to approve once variables changed.

@@ -33,7 +36,7 @@
font-size: var(--font-xlarge);
text-transform: capitalize;
font-weight: var(--font-weight-bold);
color: var(--color-highlight);
color: white;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not use --color-text instead of white

@Johnston97 Johnston97 closed this Nov 25, 2019
@Johnston97 Johnston97 deleted the minorUxChanges branch November 25, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants