-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FS 121: materiality chat agent #59
Conversation
… redis-insight with configuration sidecar
@@ -37,7 +37,7 @@ WS_URL=ws://localhost:8250/ws | |||
# llm | |||
ANSWER_AGENT_LLM="mistral" | |||
INTENT_AGENT_LLM="openai" | |||
REPORT_AGENT_LLM="mistral" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why get Diana to implement Mistral and then just change it back again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want the report agent on openai because the file processing is more advanced. We want Mistral to be able to handle "chat_with_file" method so that if someone did have it on Mistral the app wouldn't crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed more complete this way, but that's fair, we could have split that work into a tech-debt ticket instead
materiality_files = await self.select_material_files(company_name) | ||
if not materiality_files: | ||
logger.info(f"No materiality reference documents could be found for {company_name}") | ||
return {} # TODO this needs fixing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs fixing apparently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll just leave it as is (and remove the comment)
… found. tweak to report director messaging
I asked "what material topics affect the company alpkit" and the supervisior was called 8 times instead of 4
|
same happened when i tried octopush energy - which I thought might have been included in the oil and gas section.... |
Description
https://scottlogic.atlassian.net/browse/FS-121
Changelog