Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-109/Add Report to Prompt #57

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gaganahluwalia
Copy link
Collaborator

@gaganahluwalia gaganahluwalia commented Dec 18, 2024

Description

This change is for the ticket FS-109, and to add report to Intent and Suggestions agent.

Changelog

  • Added Report to Intent Prompt
  • Added Report to Suggestions prompt

@gaganahluwalia gaganahluwalia changed the title Fs 109/add prompt to report FS-109/Add Report to Prompt Dec 18, 2024
Copy link
Collaborator

@IMladjenovic IMladjenovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, there's been confusion with the ticket, I'll update the ticket to be more clear

@@ -1,4 +1,4 @@
description: "Intent"
description: 'Intent'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented on the other PR, can we keep these as double quotes for now?

user_prompt_template: 'intent'
user_prompt_args:
chat_history: []
question: 'provide a list of companies with the highest ESG scores in the Technology sector?'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant to this PR?

@@ -83,6 +83,20 @@ def clear_session_file_uploads():
set_session(UPLOADS_META_SESSION_KEY, [])


def get_uploaded_file_content() -> str | None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, unfortunately I think there has been some confusion with this ticket, I'll update the ticket to be more clear. "Report" was meant to be the report generated for the user by the Report Agent / report flow, not the file that was uploaded (whilst we have been commonly testing InferESG with Sustainability Reports, we have been describing these input files as "Narrative Files")

@@ -13,7 +13,7 @@
engine = PromptEngine()


async def search_urls(search_query, num_results=10) -> str:
async def search_urls(search_query, num_results=30) -> str:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be part of this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IMladjenovic - This MR is on top of the Web agent one...and the web agent one is yet to me merged back to the main..
How should I handle it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants