FS-123 Add report download #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mic-smith
force-pushed
the
FS-123/download-report
branch
from
2dc1992 to
d4efd9d
Compare
mic-smith
commented
Dec 12, 2024
| final_result = get_report(id) | ||
| if final_result is None: | ||
| return JSONResponse(status_code=404, content=f"Message with id {id} not found") | ||
| headers = {'Content-Disposition': 'attachment; filename="report.md"'} |
There was a problem hiding this comment.
We probably want to generate this filename, once we have the company name stored with the report.
dianaPrahoveanu-SL
approved these changes
Dec 12, 2024
IMladjenovic
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the generated report to be downloaded as markdown.
Changelog