FS-73 Add grid view #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evpearce
approved these changes
Dec 5, 2024
IMladjenovic
requested changes
Dec 6, 2024
| @@ -60,6 +69,20 @@ async def question(question: str) -> ChatResponse: | |||
| return response | |||
|
|
|||
|
|
|||
| async def __get_final_answer(question: str, intent_json: dict) -> dict[str, Any]: | |||
There was a problem hiding this comment.
can we call this __create_final_answer
| reasoning=try_pretty_print(current_scratchpad)) | ||
|
|
||
| final_answer = await get_answer_agent().invoke(question) | ||
| update_session_chat(role="system", content=final_answer) | ||
| final_answer = {} |
There was a problem hiding this comment.
Can we use a dataclass for this instead?
from typings import Optional
from dataclasses import dataclass
@dataclass
class FinalAnswer:
message: Optional[str] = ""
dataset: Optional[str] = None
IMladjenovic
reviewed
Dec 9, 2024
| @@ -20,6 +21,11 @@ | |||
| engine = PromptEngine() | |||
| director_prompt = engine.load_prompt("chat_director") | |||
|
|
|||
| @dataclass | |||
| class FinalAnswer: | |||
| message: Optional[str] = "" | |||
There was a problem hiding this comment.
I made a mistake with this suggestion, this should be message: str = "". The Optional is saying that message can be type str or None, however, we are defaulting this to empty string so saying it can be None doesn't make sense
mic-smith
force-pushed
the
FS-73/dataset-grid
branch
from
1f1d9c3 to
eefebfb
Compare
IMladjenovic
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a grid view
Changelog