FS-76 Update agent selection prompt #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evpearce
changed the title
IMladjenovic
requested changes
Dec 6, 2024
| @@ -0,0 +1,85 @@ | |||
| description: "Agent selection" | |||
backend/src/router.py
Outdated
| async def build_plan(task, llm: LLM, scratchpad, model): | ||
| best_next_step_prompt = build_best_next_step_prompt(task, scratchpad) | ||
| agent_selection_system_prompt = build_agent_selection_system_prompt(task, scratchpad) |
There was a problem hiding this comment.
Could bring the creation of the system prompt back in here, we don't often extract it out like this. If you are looking to keep the print stuff in, then keeping it in a separate function like pretty_log and update the prints to log.infos
There was a problem hiding this comment.
ha! I thought I had left some print statements in but did a codewide search for console.log and nothing came up - I'll take them out and change this too
IMladjenovic
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://scottlogic.atlassian.net/browse/FS-76
Previously the WebAgent was being selected when the DatastoreAgent should have been and vice versa. I have tried to fix it and added prompt foo tests to assert this.
Some of my changes are formatting, I don't think the previous team had consistent formatting but I think that we are all using the same formatter now? Hence I have kept the changes
Changelog