Push the FS 77 Changes related to the complex queries #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMladjenovic
reviewed
Nov 7, 2024
.env.example
Outdated
| ROUTER_MODEL="gpt-4o-mini" | ||
| FILE_AGENT_MODEL="gpt-4o-mini" | ||
| SUGGESTIONS_MODEL="gpt-4o-mini" | ||
| REDIS_HOST="localhost" |
There was a problem hiding this comment.
Can we move REDIS condig somewhere else in this file? I don't think it fits under # model
There was a problem hiding this comment.
It's done, I have moved it up.
mic-smith
reviewed
Nov 8, 2024
|
|
||
| When returning a value, always remove the `-` sign before the number. | ||
| 8. **Expense Handling**: |
There was a problem hiding this comment.
Do we need still need this expense handling logic?
There was a problem hiding this comment.
We don't actually need this. I just labelled the whole validation prompt. There is a lot of legacy code related to InferGPT, so I believe we should create a Ticket later on to remove all that.
mic-smith
approved these changes
Nov 8, 2024
IMladjenovic
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are for the US - FS77, where complex queries were not working
Changelog