FS-78: Add prompts and datastore changes from InferESG PoC #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLeopard99
force-pushed
the
FS-78/add-prompts-from-poc
branch
2 times, most recently
from
54efa5b to
1e688aa
Compare
mic-smith
reviewed
Oct 30, 2024
|
|
||
| Spending is negative | ||
| You must return a json result: | ||
| { |
There was a problem hiding this comment.
Does this change from single boolean return to json not need a corresponding change in the supervisor.py is_valid_answer to check the new is_valid property?
There was a problem hiding this comment.
It looks like Gagan has since changed this file so no changes needed from this PR anymore
CLeopard99
force-pushed
the
FS-78/add-prompts-from-poc
branch
from
1e688aa to
ce6e9e7
Compare
evpearce
force-pushed
the
FS-78/add-prompts-from-poc
branch
3 times, most recently
from
faeca41 to
d0d1a57
Compare
evpearce
force-pushed
the
FS-78/add-prompts-from-poc
branch
from
d0d1a57 to
1f9e43e
Compare
evpearce
approved these changes
Nov 14, 2024
mic-smith
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.