-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from infura to generic RPC URLS #636
Conversation
✅ Deploy Preview for jolly-shaw-20fe62 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
60bfdcb
to
354a5e1
Compare
e90b171
to
fa4b3e9
Compare
fa4b3e9
to
42ed7b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Left one question!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jferas, looks good overall. A few small comments, plus I tacked on a commit (as mentioned) for some CNS resolution stuff I found while testing it out.
edb08fd
to
78a8c2b
Compare
Coverage after merging generic-rpc-urls into master will be
Coverage Report
|
Beginning work for #484