Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced UI features #133

Merged
merged 11 commits into from
Apr 1, 2021
Merged

Advanced UI features #133

merged 11 commits into from
Apr 1, 2021

Conversation

mds1
Copy link
Collaborator

@mds1 mds1 commented Mar 19, 2021

Closes #124, closes #106 (moves one task from #106 into #135 since I want to think of the cleanest way to do that and there's more pressing functionality first). Changes:

  1. Export Private Key Of Receiving Stealth Address
  2. Define start and end blocks for receive Announcement scanning
  3. Send to a general ETH address using recovered TX pub key, transaction hash, or specific Public Key
  4. Include a Payload Extension when sending
  5. Display Payload Extension on receives (should this be there even in non-advanced mode?)

Notes:

  • The advanced toggle is in the footer
  • Items 1, 2, and 3 are advanced-mode only feature. Items 4 and 5 are always present
  • When advanced mode is on, the 🧙 emoji is shown in the top right with tooltip on hover.
  • Settings such as dark mode, start and end blocks, and advanced mode toggle are stored in local storage in a new Settings store (custom private key for scanning is intentionally not stored)

@mds1 mds1 force-pushed the advanced-ui-features branch from ead6623 to b3d6d4c Compare March 19, 2021 20:54
mds1 added 3 commits March 19, 2021 15:37
- Disable send form inputs when send is in progress
- Disable Hide and Withdraw buttons when withdraw is in progress
@mds1 mds1 force-pushed the advanced-ui-features branch from 348b60a to c1faf3e Compare March 19, 2021 22:37
@mds1 mds1 force-pushed the advanced-ui-features branch from 3a06cb1 to 3c6f1a2 Compare March 29, 2021 21:26
@mds1 mds1 marked this pull request as ready for review March 29, 2021 21:28
@mds1 mds1 requested a review from apbendi March 29, 2021 21:28
@mds1 mds1 force-pushed the advanced-ui-features branch from 3c6f1a2 to 850bf71 Compare March 29, 2021 21:29
Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks and works great! Really nice work on this— the features are all helpful. I like the memo functionality a lot and think it's good to leave it in by default.

A couple of very minor nits:

  1. When exporting a private key from MetaMask, it defaults to not having the 0x prefix. Given this, I wonder if it would be better UX not to require it:

Screen Shot 2021-03-30 at 5 22 17 PM

  1. When typing in a memo, it's unclear how much more I will be able to type, or how much I have to delete, to fit in the space available. Due to code points in Unicode, their won't be any easy way to give a "character" limit, but I wonder if we could have some kind of progress bar or little circle-pie-chart type thing that fills up or shrinks based on the bytes used as the user types?

@mds1
Copy link
Collaborator Author

mds1 commented Apr 1, 2021

Added support for both 1 and 2 in the last two commits

@mds1 mds1 mentioned this pull request Apr 1, 2021
@apbendi
Copy link
Member

apbendi commented Apr 1, 2021

Looks and works great. Nice 👍

@apbendi apbendi merged commit c892d0f into master Apr 1, 2021
@apbendi apbendi deleted the advanced-ui-features branch October 22, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send Fields Should Not Be Editable While TX is Pending Advanced UI Features
2 participants