-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced UI features #133
Advanced UI features #133
Conversation
ead6623
to
b3d6d4c
Compare
- Disable send form inputs when send is in progress - Disable Hide and Withdraw buttons when withdraw is in progress
348b60a
to
c1faf3e
Compare
3a06cb1
to
3c6f1a2
Compare
3c6f1a2
to
850bf71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks and works great! Really nice work on this— the features are all helpful. I like the memo functionality a lot and think it's good to leave it in by default.
A couple of very minor nits:
- When exporting a private key from MetaMask, it defaults to not having the
0x
prefix. Given this, I wonder if it would be better UX not to require it:
- When typing in a memo, it's unclear how much more I will be able to type, or how much I have to delete, to fit in the space available. Due to code points in Unicode, their won't be any easy way to give a "character" limit, but I wonder if we could have some kind of progress bar or little circle-pie-chart type thing that fills up or shrinks based on the bytes used as the user types?
Added support for both 1 and 2 in the last two commits |
Looks and works great. Nice 👍 |
Closes #124, closes #106 (moves one task from #106 into #135 since I want to think of the cleanest way to do that and there's more pressing functionality first). Changes:
Notes: