Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature malleability test and emit an event when incrementNonce is called #9

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

garyghayrat
Copy link
Member

@garyghayrat garyghayrat commented Feb 19, 2024

  1. Emit NonceIncremented event in incrementNonce.
  2. Test a different stealthMetaAddress can't be set with a manipulated signature.

@garyghayrat garyghayrat marked this pull request as ready for review February 20, 2024 16:09
@garyghayrat garyghayrat requested review from mds1 and apbendi February 20, 2024 16:10
@garyghayrat garyghayrat changed the title Add signature malleability check and emit an event when incrementNonce is called Add signature malleability test and emit an event when incrementNonce is called Feb 20, 2024
test/ERC6538Registry.t.sol Outdated Show resolved Hide resolved
@garyghayrat garyghayrat requested review from apbendi and mds1 March 5, 2024 20:30
Copy link

github-actions bot commented Apr 8, 2024

Coverage after merging add-signature-check-and-emit-event into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   ERC5564Announcer.sol100%100%100%100%
   ERC6538Registry.sol96.67%75%100%100%98

Copy link
Member

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @garyghayrat

@garyghayrat garyghayrat merged commit e62ebe9 into main Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants