Various Improvements and Refactors to Test Suite #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbendi
changed the base branch from
erc-5564-use-address-only
to
erc-6538-use-address-only
garyghayrat
reviewed
Feb 2, 2024
| return (address(0), RecoverError.InvalidSignatureS, s); | ||
| } | ||
| chainId1 = bound(chainId1, 1, 2 ** 64 - 1); | ||
| chainId2 = bound(chainId2, 1, 2 ** 64 - 1); |
There was a problem hiding this comment.
why do we wanna use 2 ** 64 - 1 here?
There was a problem hiding this comment.
This is the highest supported chainId so there's no reason not to fuzz across the whole range.
garyghayrat
approved these changes
Feb 2, 2024
garyghayrat
reviewed
Feb 2, 2024
* Test internal variable initialization in registry constructor tests
* Improvements to domain separator test
* Improvements to the RegisteryKeys tests
* Naming improvements to registerKeysOnBehalf tests
* Update test imports and remove duplicated import
* Refactor signature test helpers for test simplicity
* Simplify mock contract for ERC1271 signatures
* Remove redundant test and add missing ones for register on behalf
* Minor cleanup to increment nonce test
* Update the EIP712Domain separator to match the spec
* Simplify Announcer test names
* Use `vm.expectRevert("")` instead of `vm.expectRevert()`
|
Coverage after merging tweaks into erc-6538-use-address-only will be
Coverage Report
|
|||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @garyghayrat, rather than cause too much churn on your PR, I did some cleanup and refactoring to your PR in my own branch. You can review it, leave feedback, and once you're ok with my changes, we can merge it in to your branch. Then we can ask Matt & Tony for final sign off on your PR before merging it into main and getting community input in advance of the audit. Thanks for bearing with me in this process!
Also note, the only non-test change was to update the DOMAIN_SEPARATOR to correctly confirm to the spec. The name of the param should always be
verifyingContract.resolves #6