Arbitrum Deploy scripts #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
force-pushed
the
feature/add-arbitrum-deploy
branch
from
5f1ed6d to
54a4b97
Compare
|
Coverage after merging feature/add-arbitrum-deploy into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||
mds1
reviewed
Jun 29, 2023
| | Name | Chain | Address | | ||
| |----------|:-------:|:-------------:| | ||
| | 1inch Router Factory | Optimism | 0xDfb453656A14c8e9ad3F4095483CE3328977eb47 | | ||
| | 1inch Router Factory | Aribitrum | 0x8a33e6288d155aDB1d368838CB91E01d30C66eC1| |
There was a problem hiding this comment.
Do we have any already-deployed child contracts (i.e. contracts deployed from the factory) from the benchmarks that we should also document here?
There was a problem hiding this comment.
Not on either chain yet, we do have a bunch for perpetual on Optimism which I can add to that repo. I can also deploy the child contracts for 1inch for a few tokens to fill out the table.
mds1
reviewed
Jun 29, 2023
Comment on lines
+15
to
+24
| IV5AggregationRouter v5AggregationRouter = | ||
| IV5AggregationRouter(0x1111111254EEB25477B68fb85Ed929f73A960582); | ||
| IV5AggregationExecutor v5AggregationExecutor = | ||
| IV5AggregationExecutor(0x454C8b4DC6a2AFfe669A3Db1633133F7d305e305); | ||
| IV4AggregationRouter v4AggregationRouter = | ||
| IV4AggregationRouter(0x1111111254fb6c44bAC0beD2854e76F90643097d); | ||
| IV4AggregationExecutor v4AggregationExecutor = | ||
| IV4AggregationExecutor(0x454C8b4DC6a2AFfe669A3Db1633133F7d305e305); | ||
|
|
||
| address WETH = 0x82aF49447D8a07e3bd95BD0d56f35241523fBab1; |
There was a problem hiding this comment.
Nit, but let's move these constants outside of the run function to make it more clear they're constants that you shouldn't have to modify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description