bridge: transaction functionality #9

wildmolasses · 2023-10-10T00:17:20Z

No description provided.

wildmolasses · 2023-10-10T00:17:35Z

Current dependencies on/for this PR:

main
- PR Update config to latest #29
  - PR Notification context #25
    - PR bridge: transaction functionality #9 👈
      - PR Add Delegate page #18
        
        PR Add table for proposals #28

This comment was auto-generated by Graphite.

netlify · 2023-10-12T14:23:17Z

✅ Deploy Preview for warm-jelly-e126f7 ready!

Name	Link
🔨 Latest commit	`c294a17`
🔍 Latest deploy log	https://app.netlify.com/sites/warm-jelly-e126f7/deploys/6537ed663f9aee000864831e
😎 Deploy Preview	https://deploy-preview-9--warm-jelly-e126f7.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

abi/WormholeL2ERC20.sol/WormholeL2ERC20.json

alexkeating

Looks good! Most things can be spun into another. Feel free to do so as you see fit.

alexkeating · 2023-10-24T02:03:06Z

pages/bridge.tsx

+    chainId: l1Config.chain.id,
+    address: l1Config.tokenAddress,
+    abi: parseAbi([
+      "function allowance(address, address) public view returns (uint256)",


It might be good to move these abis to a constants file in case we ever need to make changes

alexkeating · 2023-10-24T02:03:58Z

pages/bridge.tsx

+    isSuccess: bridgeToL1IsSuccess,
+    // error: bridgeToL1Error,
+    write: bridgeToL1,
+  } = useContractWrite(bridgeToL1Config);


It might be good to abstract these to hooks

alexkeating · 2023-10-24T02:12:56Z

hooks/useEasyWrite.ts

@@ -20,9 +21,12 @@ export const useEasyWrite = (
  const error = prepareError || writeError;
  const isLoading = prepareIsLoading || writeIsLoading;

+  useEffect(() => {
+    if (writeData?.hash) notify({ hash: writeData?.hash, status });
+  }, [notify, writeData?.hash, status]);


Does this need to be in a useEffect? Could it be an if statement outside of a useEffect?

alexkeating · 2023-10-24T02:17:29Z

pages/bridge.tsx

+                )}
+              </div>
+              <div className="mt-5">
+                {bridgeTarget === BridgeTarget.L2


We can eliminate one class of issues if we prompt the user to switch their chain. Either when they switch are try to bridge while on the wrong chain. I have an example of switching chains in the delegate page pr.

alexkeating · 2023-10-24T02:22:17Z

pages/bridge.tsx

-                >
-                  Bridge to {target.chain.name}
-                </button>
+                {bridgeTarget === BridgeTarget.L2 && needsAllowanceL1 ? (


Unrelated to this pr, but I noticed the amounts did not round nicely.

alexkeating · 2023-10-24T02:23:11Z

pages/bridge.tsx

@@ -115,6 +204,7 @@ const Bridge = () => {
                  defaultValue=""
                  aria-invalid={isAmountError}
                  aria-describedby="amount"
+                  onChange={handleInputChange}


This input can go negative

alexkeating · 2023-10-24T02:25:36Z

components/Notifications.tsx

                            ? "Transaction succeeded"
                            : "Transaction pending"}
                        </p>
                        <p className="mt-1 text-sm text-gray-500">
                          {description}
                        </p>
                        <p className="mt-1 text-sm text-gray-500">
-                          <a href="https://etherscan.io">View on Etherscan</a>
+                          <a href={`https://etherscan.io/tx/${hash}`}>


This could be pulled out into a constant

alexkeating · 2023-10-24T02:27:27Z

pages/bridge.tsx

+    data: bridgeToL1Response,
+    isLoading: bridgeToL1IsLoading,
+    isSuccess: bridgeToL1IsSuccess,
+    // error: bridgeToL1Error,


Might be good to delete and make an issue for these.

wildmolasses · 2023-10-24T16:13:14Z

Merge activity

Oct 24, 12:13 PM: @wildmolasses started a stack merge that includes this pull request via Graphite.
Oct 24, 12:14 PM: Graphite rebased this pull request as part of a merge.
Oct 24, 12:15 PM: @wildmolasses merged this pull request with Graphite.

This was referenced Oct 10, 2023

add vscode settings for module resolution #2

Merged

Layout and page scaffold #3

Merged

Bridge page #4

Merged

wildmolasses mentioned this pull request Oct 10, 2023

Potentially handle quoteDelivery issue #8

Merged

wildmolasses force-pushed the 09-25-Bridge_page branch from e03e4af to cd11484 Compare October 12, 2023 12:58

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from 66bb0cb to 01db6e6 Compare October 12, 2023 12:58

wildmolasses changed the base branch from 09-25-Bridge_page to main October 12, 2023 14:23

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from 01db6e6 to 50b6a86 Compare October 12, 2023 14:23

wildmolasses changed the base branch from main to 10-12-Change_networks_to_goerli_OP_goerli October 12, 2023 14:30

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from 50b6a86 to d0894a0 Compare October 12, 2023 14:30

wildmolasses mentioned this pull request Oct 12, 2023

Change networks to goerli, OP goerli #17

Merged

alexkeating changed the base branch from 10-12-Change_networks_to_goerli_OP_goerli to main October 12, 2023 15:08

alexkeating mentioned this pull request Oct 12, 2023

Add Delegate page #18

Merged

wildmolasses changed the base branch from main to 10-12-Nav_bar October 12, 2023 15:14

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from d0894a0 to edec8ff Compare October 12, 2023 15:14

wildmolasses mentioned this pull request Oct 12, 2023

Style spacing on nav bar #19

Merged

wildmolasses force-pushed the 10-12-Nav_bar branch from 4bcc710 to 82e4e25 Compare October 13, 2023 10:09

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from edec8ff to 0a6e560 Compare October 13, 2023 10:09

wildmolasses force-pushed the 10-12-Nav_bar branch from 82e4e25 to b90fc69 Compare October 13, 2023 10:11

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from 0a6e560 to 2626059 Compare October 13, 2023 10:11

wildmolasses mentioned this pull request Oct 13, 2023

Debug panel #21

Merged

alexkeating reviewed Oct 16, 2023

View reviewed changes

abi/WormholeL2ERC20.sol/WormholeL2ERC20.json Outdated Show resolved Hide resolved

alexkeating changed the base branch from 10-12-Nav_bar to main October 16, 2023 16:58

alexkeating force-pushed the 10-10-bridge_transaction_functionality branch from 2626059 to 2249eb1 Compare October 16, 2023 16:58

wildmolasses mentioned this pull request Oct 17, 2023

prefer human-readable ABI #23

Merged

wildmolasses changed the base branch from main to 10-17-prefer_human-readable_ABI October 17, 2023 10:28

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch 2 times, most recently from 1886900 to 86c06c7 Compare October 17, 2023 10:39

wildmolasses mentioned this pull request Oct 17, 2023

Notification context #25

Merged

alexkeating changed the base branch from 10-17-prefer_human-readable_ABI to main October 17, 2023 17:28

alexkeating force-pushed the 10-10-bridge_transaction_functionality branch from 86c06c7 to 7f77d26 Compare October 18, 2023 13:07

alexkeating mentioned this pull request Oct 18, 2023

Add table for proposals #28

Merged

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from 7f77d26 to 92808ae Compare October 19, 2023 10:08

wildmolasses changed the base branch from main to 10-17-notifications October 19, 2023 10:08

wildmolasses force-pushed the 10-17-notifications branch from 7352c24 to 2eeda49 Compare October 19, 2023 10:11

wildmolasses mentioned this pull request Oct 19, 2023

Update config to latest #29

Merged

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch 2 times, most recently from aa36681 to 2329c9b Compare October 19, 2023 11:39

wildmolasses force-pushed the 10-17-notifications branch from 2eeda49 to 9e93f57 Compare October 19, 2023 22:55

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from 2329c9b to af3b62d Compare October 19, 2023 22:55

alexkeating changed the base branch from 10-17-notifications to main October 22, 2023 03:31

wildmolasses changed the base branch from main to 10-17-notifications October 23, 2023 15:18

wildmolasses force-pushed the 10-17-notifications branch from 9e93f57 to c9c52ed Compare October 23, 2023 15:19

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from af3b62d to 1cf9072 Compare October 23, 2023 15:19

wildmolasses marked this pull request as ready for review October 23, 2023 15:19

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch 2 times, most recently from 222c8ab to e637519 Compare October 23, 2023 20:40

alexkeating approved these changes Oct 24, 2023

View reviewed changes

wildmolasses changed the base branch from 10-17-notifications to main October 24, 2023 16:13

bridge: transaction functionality

c294a17

wildmolasses force-pushed the 10-10-bridge_transaction_functionality branch from e637519 to c294a17 Compare October 24, 2023 16:14

wildmolasses merged commit 6dc610d into main Oct 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bridge: transaction functionality #9

bridge: transaction functionality #9

wildmolasses commented Oct 10, 2023

wildmolasses commented Oct 10, 2023 •

edited

Loading

netlify bot commented Oct 12, 2023 •

edited

Loading

alexkeating left a comment

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

alexkeating Oct 24, 2023

wildmolasses commented Oct 24, 2023 •

edited

Loading

bridge: transaction functionality #9

bridge: transaction functionality #9

Conversation

wildmolasses commented Oct 10, 2023

wildmolasses commented Oct 10, 2023 • edited Loading

netlify bot commented Oct 12, 2023 • edited Loading

✅ Deploy Preview for warm-jelly-e126f7 ready!

alexkeating left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildmolasses commented Oct 24, 2023 • edited Loading

Merge activity

wildmolasses commented Oct 10, 2023 •

edited

Loading

netlify bot commented Oct 12, 2023 •

edited

Loading

wildmolasses commented Oct 24, 2023 •

edited

Loading