Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jazzicon to delegate #174

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Add jazzicon to delegate #174

merged 2 commits into from
Dec 20, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Dec 12, 2023

Description

  • Add jazzicon if ENS avatar is missing
    Screenshot from 2023-12-12 10-53-33

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for l2-flexible-voting ready!

Name Link
🔨 Latest commit a3d0c89
🔍 Latest deploy log https://app.netlify.com/sites/l2-flexible-voting/deploys/658332ba72a65b0008b3dfd0
😎 Deploy Preview https://deploy-preview-174--l2-flexible-voting.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexkeating
Copy link
Collaborator Author

alexkeating commented Dec 12, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alexkeating alexkeating marked this pull request as ready for review December 12, 2023 15:59
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, otherwise lgtm

<InformationCircleIcon
id="delegate-address-information"
className="h-4"
className="h-4 self-start"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="h-4 self-start"
className="h-4"

screenshot shows the info icon is no longer vertically aligned w the text; removing this is the fix. curious, did you not want the icon centered vertically anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good question. I thought it looked better higher, but if you guys think it looks worse I can change it back

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my preference is centered vertically -- or next to the "Delgated to" rather than the address

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexkeating alexkeating merged commit 82b3e0f into main Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants