Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle delegate page #137

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Restyle delegate page #137

merged 5 commits into from
Nov 16, 2023

Conversation

alexkeating
Copy link
Collaborator

@alexkeating alexkeating commented Nov 14, 2023 •
edited
Loading

Description

  • Make the delegate page match more with the bridge page, such as:
    • Put the same border around it
    • Put the middle section showing voting power in the same grey box as the network/token on the bridge page
    • Put the button in the middle
  • Move the message “POOL.fv determines PoolTogether voting power on Optimism Goerli.” above the balances
  • The message “Note: They must be delegated before a proposal has been proposed in order to be considered for that proposal.” is moved into a tooltip with an “(i)” next to the address delegated to. The copy was updated to “Voting power for a given proposal is based on delegations at the time the proposal was created.”
  • Instead of a grey box, we now use the same border and white background when the proposal is not yet bridged to L2, and we changed the copy to say “Proposal is not yet bridged to L2”

@alexkeating alexkeating mentioned this pull request Nov 14, 2023
Merged
@alexkeating
Copy link
Collaborator Author

alexkeating commented Nov 14, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alexkeating alexkeating mentioned this pull request Nov 14, 2023
Merged
@alexkeating alexkeating marked this pull request as ready for review November 14, 2023 15:50
@alexkeating alexkeating force-pushed the bug/update-delegate-amount branch from 42d6b55 to 95e68d1 Compare November 16, 2023 08:24
@alexkeating alexkeating force-pushed the chore/delegate-page-style-changes branch from 96b457e to 0d6a409 Compare November 16, 2023 08:25
@alexkeating alexkeating mentioned this pull request Nov 16, 2023
Merged
@wildmolasses wildmolasses changed the base branch from bug/update-delegate-amount to main November 16, 2023 08:41
@wildmolasses wildmolasses force-pushed the chore/delegate-page-style-changes branch from 0d6a409 to 25181cb Compare November 16, 2023 08:41
@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023 •
edited
Loading

✅ Deploy Preview for l2-flexible-voting ready!

Name Link
🔨 Latest commit 44f0ba5
🔍 Latest deploy log https://app.netlify.com/sites/l2-flexible-voting/deploys/6555f6fdd873d30008df6d63
😎 Deploy Preview https://deploy-preview-137--l2-flexible-voting.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wildmolasses
wildmolasses reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found 1 issue, what do you think?

pages/[id]/delegate.tsx
<div className="flex items-center gap-1.5 text-gray-600 py-2 mb-2 ">
<InformationCircleIcon className="h-4" />
<p className="text-sm ">
{mounted && l2.token?.symbol} determines {config.name} voting power on{' '}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-16 at 11 51 31 AM

[ blank ] determines PoolTogether voting power on Optimism Goerli

currently, token info is gotten via useBalances hook, but since we don't have an address, we don't have a balance, therefore this token symbol isn't loading

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tracking in #140

@wildmolasses wildmolasses force-pushed the chore/delegate-page-style-changes branch from cc21a3d to 346e71f Compare November 16, 2023 09:54
@wildmolasses wildmolasses force-pushed the chore/delegate-page-style-changes branch from 346e71f to 231adad Compare November 16, 2023 10:59
@wildmolasses wildmolasses force-pushed the chore/delegate-page-style-changes branch from d571799 to 44f0ba5 Compare November 16, 2023 11:03
@wildmolasses wildmolasses self-requested a review November 16, 2023 11:04
wildmolasses
wildmolasses approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wildmolasses wildmolasses merged commit e887dcc into main Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyghayrat garyghayrat garyghayrat left review comments

@wildmolasses wildmolasses wildmolasses approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexkeating @wildmolasses @garyghayrat