Change token name for approval and disable approval when the balance is too low #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for l2-flexible-voting ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexkeating
changed the title
wildmolasses
requested changes
Nov 13, 2023
| @@ -68,6 +68,7 @@ const Bridge = () => { | |||
| }); | |||
|
|
|||
| const needsAllowanceL1 = (allowanceL1 || 0) < rawAmount; | |||
| const isSufficientBalance = (source.token?.value || 0) >= rawAmount; | |||
There was a problem hiding this comment.
[arbitrary place to leave comment]
functionality currently not working when i have 0 balance. Asks me to set approval, no error displayed (although, red error icon displays in input box)
alexkeating
force-pushed
the
chore/change-approval-name
branch
from
66f2302 to
69fa5e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description