Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return storage error if DynamoDB returns an empty response #8

Merged
merged 1 commit into from
May 30, 2024
Merged

Return storage error if DynamoDB returns an empty response #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions storage/dynamodb/dynamodb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,12 @@
},
TableName: aws.String(c.table)},
)

// Check for storage.ErrorNotFound
if err != nil {

Check failure on line 113 in storage/dynamodb/dynamodb.go

View workflow job for this annotation

GitHub Actions / Lint 

ifElseChain: rewrite if-else to switch statement (gocritic)
return resp, fmt.Errorf("getting item from dynamodb: %v", err)
} else if len(resp.Item) < 1 {
return resp, storage.ErrNotFound
} else {
return resp, nil
}
Expand Down Expand Up @@ -351,11 +355,6 @@
}

storageKey := toStorageKey(keyResp)

if err != nil {
return storage.Keys{}, err
}

return storageKey, err
}

Expand Down
Loading