Merge pull request #8 from ErikBZ/bugfix/INT-6127-return-storage-error

Return storage error if DynamoDB returns an empty response
ScienceLogic · May 30, 2024 · 981df85 · 981df85
2 parents 1a6c803 + aa3232b
commit 981df85
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/storage/dynamodb/dynamodb.go b/storage/dynamodb/dynamodb.go
@@ -108,8 +108,12 @@ func (c *conn) getItem(content_type string, id string) (*dynamodb.GetItemOutput,
 		},
 		TableName: aws.String(c.table)},
 	)
+
+	// Check for storage.ErrorNotFound
 	if err != nil {
 		return resp, fmt.Errorf("getting item from dynamodb: %v", err)
+	} else if len(resp.Item) < 1 {
+		return resp, storage.ErrNotFound
 	} else {
 		return resp, nil
 	}
@@ -351,11 +355,6 @@ func (c *conn) GetKeys() (storage.Keys, error) {
 	}
 
 	storageKey := toStorageKey(keyResp)
-
-	if err != nil {
-		return storage.Keys{}, err
-	}
-
 	return storageKey, err
 }