-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move setup.cfg to pyproject.toml #5262
Conversation
28fc29a
to
34d41f7
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5262 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 88 88
Lines 22279 22279
Branches 5355 5355
=======================================
Hits 19898 19898
Misses 1635 1635
Partials 746 746 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Possibly a bit worrying, as it is so essential for UM files support. |
It is available - via Conda (It's also essential to benchmark file generation) |
Thanks to @trexfeathers, #5259 has landed, so I'll rebase and refactor the |
I'll also check to see if any changes I've made here make any of the dev docs stale wrt updating PyPI deps (which now live under the |
|
Done i.e., nothing to do in the docs (that I can see) |
My point was, if we now have "one true list" of dependencies (for which 👍 🥇!) , will this also remove it from the conda deps ? |
Yeah, from what I can see the ecosystem isn't quite there yet... well, not that I know of, but I'm certainly not an authority on this stuff. I may ask around at scipy 2023 and see what the word is 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK this is ready to go, but needs a conflict resolved first.
On it now... |
@trexfeathers Hmmmm if only we had Ping @ESadek-MO |
@trexfeathers Awesome, cheers 🍻 |
* upstream/main: Updated environment lockfiles (SciTools#5270) Drop python3.8 support (SciTools#5269) build wheel from sdist, not src (SciTools#5266) Lazy netcdf saves (SciTools#5191) move setup.cfg to pyproject.toml (SciTools#5262) Support Python 3.11 (SciTools#5226) Remove Resolve test workaround (SciTools#5267) add missing whatsnew entry (SciTools#5265)
* upstream/main: (61 commits) Updated environment lockfiles (SciTools#5270) Drop python3.8 support (SciTools#5269) build wheel from sdist, not src (SciTools#5266) Lazy netcdf saves (SciTools#5191) move setup.cfg to pyproject.toml (SciTools#5262) Support Python 3.11 (SciTools#5226) Remove Resolve test workaround (SciTools#5267) add missing whatsnew entry (SciTools#5265) make help (SciTools#5258) automate pypi manifest checking (SciTools#5259) drop sphinxcontrib-napoleon (SciTools#5263) add missing test result data (SciTools#5260) fix indentation and remove ref to ssstack (SciTools#5256) review actions update .git-blame-ignore-revs adopt codespell Adopt sphinx design (SciTools#5127) Bump scitools/workflows from 2023.04.2 to 2023.04.3 (SciTools#5253) refresh manual pypi publish instructions (SciTools#5252) Updated environment lockfiles (SciTools#5250) ...
🚀 Pull Request
Description
This PR migrates the
setup.cfg
to thepyproject.toml
.For the motivation, see pep621.
Note that,
flake8
configuration now lives in the dedicated.flake8
file. When we migrate totox
, then the.flake8
can then be migrated to thetox.ini
- see here. Additionally, theflake8
configuration may be further consolidated if we choose to adopt ruff 😉pyproject.toml
. Rather, they are now explicitly defined under therequirements
directory in*.txt
files. Most devs have fallen foul of updatingconda
dependencies and forgotten aboutpypi
dependencies, as they were obfuscated within thesetup.cfg
. Hopefully, banking all our dependencies within the same directory will alleviate this issueMANIFEST.in
requires to be updated to include therequirements/*.txt
PyPI dependency filesmo_pack
is not available on PyPI, so it has been removeddev
,docs
andtest
, instead ofdocs
,test
andall
(which includeddev
,docs
andtest
via using convenience syntax within thesetup.cfg
)Reference:
Consult Iris pull request check list