Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for older iris versions (<3.10) #431

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Fix for older iris versions (<3.10) #431

merged 4 commits into from
Nov 7, 2024

Conversation

stephenworsley
Copy link
Contributor

Addresses #429.

@stephenworsley stephenworsley mentioned this pull request Nov 6, 2024
Closed
@ESadek-MO ESadek-MO self-requested a review November 7, 2024 10:14
ESadek-MO
ESadek-MO approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @stephenworsley

@stephenworsley
Copy link
Contributor Author

For the record, the readthedocs errors seem to have been caused by this block of code
here: https://github.com/SciTools/cf-units/blob/446fcc2323c01146448366593a2766e62b1a9e82/cf_units/__init__.py#L186-L191

it seems like this might have been caused by there being no existing setting for LC_NUMERIC (or, somehow, the existing setting was invalid), so when cf_units attempts to revert it back to the original setting, it breaks. I'm not sure what the defaults are for readthedocs, but setting them explicitly seems to do the job.

@stephenworsley stephenworsley merged commit af9a69e into SciTools:main Nov 7, 2024
15 checks passed
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Nov 7, 2024
@stephenworsley
Merge branch 'main' into esmf_args
4ac5bb8 
* main:
  Fix for older iris versions (<3.10) (SciTools#431)
  Numpy 2 fix (SciTools#426)
  Bump scitools/workflows from 2024.09.9 to 2024.10.3 (SciTools#425)
  [pre-commit.ci] pre-commit autoupdate (SciTools#421)
  Fix load_regridder docstring (SciTools#404)
  Bump peter-evans/create-pull-request from 7.0.0 to 7.0.5 (SciTools#411)
  Bump scitools/workflows from 2024.09.2 to 2024.09.9 (SciTools#416)
  Updated environment lockfiles (SciTools#414)
  add zenodo badge, update LICENSE (SciTools#419)
  Authorise the pull request using the SciTools App token. (SciTools#418)
  remove references to SciTools-incubator (SciTools#417)
  Updated environment lockfiles (SciTools#393)
  Bump scitools/workflows from 2024.08.0 to 2024.09.2 (SciTools#400)
  Bump peter-evans/create-pull-request from 6.1.0 to 7.0.0 (SciTools#399)
@pp-mo pp-mo mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ESadek-MO ESadek-MO ESadek-MO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenworsley @ESadek-MO