Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unmasked connectivity bug #385

Merged
merged 12 commits into from
Jul 23, 2024
Merged

Fix unmasked connectivity bug #385

merged 12 commits into from
Jul 23, 2024

Conversation

stephenworsley
Copy link
Contributor

Closes #329.

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 98.58%. Comparing base (1772591) to head (80246e7).

Files Patch % Lines
esmf_regrid/experimental/unstructured_scheme.py 37.50% 5 Missing ⚠️
esmf_regrid/schemes.py 58.33% 5 Missing ⚠️
...egrid/tests/unit/schemes/test__mesh_to_MeshInfo.py 50.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   98.92%   98.58%   -0.35%     
==========================================
  Files          37       37              
  Lines        4196     4230      +34     
==========================================
+ Hits         4151     4170      +19     
- Misses         45       60      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pp-mo
pp-mo approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks fine.
Tiny suggestion for the implementation.

@pp-mo pp-mo merged commit 5354829 into SciTools:main Jul 23, 2024
15 of 16 checks passed
@pp-mo
Copy link
Member

pp-mo commented Jul 23, 2024

All good.
We are expecting benchmarks to fail here.

stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Jul 23, 2024
@stephenworsley
Merge branch 'main' into boundless_coords
6818a1d 
* main:
  Fix unmasked connectivity bug (SciTools#385)

# Conflicts:
#	esmf_regrid/schemes.py
@pp-mo pp-mo mentioned this pull request Jul 24, 2024
Closed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 98.58%. Comparing base (1772591) to head (80246e7).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
esmf_regrid/experimental/unstructured_scheme.py 37.50% 5 Missing ⚠️
esmf_regrid/schemes.py 58.33% 5 Missing ⚠️
...egrid/tests/unit/schemes/test__mesh_to_MeshInfo.py 50.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   98.92%   98.58%   -0.35%     
==========================================
  Files          37       37              
  Lines        4196     4230      +34     
==========================================
+ Hits         4151     4170      +19     
- Misses         45       60      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when face node connectivity is not masked
3 participants
@stephenworsley @pp-mo @codecov-commenter