Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing masks for nearest scheme #369

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bouweandela
Copy link
Member

Closes #368

@bouweandela bouweandela marked this pull request as ready for review June 18, 2024 11:37
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.94%. Comparing base (fdd2051) to head (83cf362).

Files Patch % Lines
esmf_regrid/esmf_regridder.py 93.75% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   98.92%   98.94%   +0.01%     
==========================================
  Files          37       37              
  Lines        4196     4265      +69     
==========================================
+ Hits         4151     4220      +69     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

use_src_mask and use_tgt_mask with nearest regridding scheme do not produce correct results
2 participants