Initial setup of QA pre-commit tools [cf-units] #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressed in this branch
existing known Deprecation warnings
- Required lots of additions to the Ruff ignore list - Extra additions to mypy ignore list - Autofixes from Ruff linter - Fixes from codespell
- Removed some duplicate ruff ignores - Reorded some subsections
- Added: `force-sort-within-sections = true` - Auto updated files resultig from above - file specific ignores
- Trailing witespace - No neline at end of file - Some Ruff linting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 58.41% 58.40% -0.02%
==========================================
Files 62 62
Lines 6435 6433 -2
Branches 1150 1150
==========================================
- Hits 3759 3757 -2
Misses 2385 2385
Partials 291 291 ☔ View full report in Codecov by Sentry. |
- Add trailing / to mypy exclude paths
Added extra ignores in mypy for _udunits generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Added following pre-commit hooks:
sp-repo-reviewwas already setup for cf-units, but have updated the ignore list as various tests now pass.ruffwas enabled, but with only selected tests. Have enabled "all" tests.For all QA tools above, the results of any "auto-fixes" have been included in this repo, mainly fixes for:
All other failing tests have been added to ignore lists. See separate issues: