Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change SCCNonlinearProblem fields #884

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

SciMLSensitivity/Core5 failure seems random and unrelated, the failing test passed locally.

@AayushSabharwal AayushSabharwal force-pushed the as/scc-refactor branch 4 times, most recently from c6268c8 to e8238e2 Compare December 3, 2024 10:17
@ChrisRackauckas ChrisRackauckas merged commit dae2c41 into SciML:master Dec 3, 2024
36 of 51 checks passed
parameter_object::Par
# NonlinearFunction with `f = Returns(nothing)`
f::F
p::Par
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait what is this p? How does it relate to the actual p of the probs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This p is the parameter object for SII. Since the parameter object is not guaranteed to be identical for all problems, the user can provide one that SII will use and that prob.f.observed will codegen for. There's a flag if all problems share the same parameter object, which aliases prob.p and functions like set_parameter! take advantage of this.

@AayushSabharwal AayushSabharwal deleted the as/scc-refactor branch December 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants