refactor: change SCCNonlinearProblem fields
#884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/scc-refactor
branch
from
093ba15
to
7f8c129
Compare
|
SciMLSensitivity/Core5 failure seems random and unrelated, the failing test passed locally. |
AayushSabharwal
force-pushed
the
as/scc-refactor
branch
4 times, most recently
from
c6268c8
to
e8238e2
Compare
AayushSabharwal
force-pushed
the
as/scc-refactor
branch
from
e8238e2
to
1dcbd1f
Compare
| parameter_object::Par | ||
| # NonlinearFunction with `f = Returns(nothing)` | ||
| f::F | ||
| p::Par |
There was a problem hiding this comment.
wait what is this p? How does it relate to the actual p of the probs?
There was a problem hiding this comment.
This p is the parameter object for SII. Since the parameter object is not guaranteed to be identical for all problems, the user can provide one that SII will use and that prob.f.observed will codegen for. There's a flag if all problems share the same parameter object, which aliases prob.p and functions like set_parameter! take advantage of this.
longemen3000
reviewed
Dec 6, 2024
| if u0 === missing && p === missing | ||
| return state_values(prob), parameter_values(prob) | ||
| end | ||
| if indp === nothing | ||
| if prob.f.sys === nothing |
There was a problem hiding this comment.
this line causes SciML/Integrals.jl#259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.