Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for smooth loss functions to RoAAwareDecreaseCondition #29

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

nicholaskl97
Copy link
Collaborator

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Previously, RoAAwareDecreaseCondition had an inequality being used to detect if the in-RoA or out-of-RoA loss should be applied. This PR replaces that inequality with a function which can be a smooth approximation of the inequality.

Additionally, this PR adds tests for fallback functions for AbstractLyapunovMinimizationCondition and AbstractLyapunovDecreaseCondition methods to improve code coverage.

@nicholaskl97 nicholaskl97 merged commit 24d9409 into master Jun 14, 2024
3 of 4 checks passed
@nicholaskl97
Copy link
Collaborator Author

@ChrisRackauckas, I noticed that the Codecov number on the home page didn't change after I merged this PR (it should have gone up and should have been higher to start). It looks like the Codecov GitHub app has been suspended for this repository. Do you know why? The GitHub apps settings page says that I don't have sufficient access to configure its installation.

@ChrisRackauckas ChrisRackauckas deleted the RoA_approximation branch June 14, 2024 19:41
@ChrisRackauckas
Copy link
Member

We had to suspend codecov for the whole org due to some issues with ssh keys. We're looking for another service that won't have the issue.

@nicholaskl97
Copy link
Collaborator Author

We had to suspend codecov for the whole org due to some issues with ssh keys. We're looking for another service that won't have the issue.

Alright. I thought it was something wrong with how I set something up, so glad to hear it's not that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants