Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaults from Blocks.SISO #334

Merged
merged 14 commits into from
Oct 4, 2024
Merged

Remove defaults from Blocks.SISO #334

merged 14 commits into from
Oct 4, 2024

Conversation

bradcarman
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The SISO component is an extendable component that provides u and y variables. These should not be have defaults at the lower level, this makes building components based on them more challenging with the MTK v9 initialization system.

@ChrisRackauckas
Copy link
Member

Test failure.

We should differentiate the args for guesses from those for the initial values. Looks like this test needs to set an initial.

@ChrisRackauckas ChrisRackauckas merged commit 90d935b into main Oct 4, 2024
8 of 9 checks passed
@ChrisRackauckas ChrisRackauckas deleted the bgc/siso_defaults branch October 5, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants