More CI #250
Open
More CI #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ArnoStrouwen
commented
Jan 11, 2024
ArnoStrouwen
commented
- What is the proper deprecation for sys.name? The suggested get_name(sys) does not seem to work.
- Downstream had no group, so I just picked the broadest one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 15.85% 15.77% -0.09%
==========================================
Files 48 48
Lines 1627 1636 +9
==========================================
Hits 258 258
- Misses 1369 1378 +9 ☔ View full report in Codecov by Sentry. |
ven-k
reviewed
Jan 16, 2024
| @@ -276,7 +276,7 @@ _damped_sine_wave(x, f, A, st, ϕ, d) = exp((st - x) * d) * A * sin(2 * π * f * | |||
|
|
|||
| for i in 1:lastindex(sources) | |||
| source = sources[i] | |||
| @info "Testing Voltage with $(source.name) source" | |||
| @info "Testing Voltage with $(source.get_name) source" | |||
There was a problem hiding this comment.
This works:
Suggested change
| @info "Testing Voltage with $(source.get_name) source" | |
| @info "Testing Voltage with $(ModelingToolkit.getname(source)) source" |
Better still - a using ModelingToolkit: getname at the top and $(getname(source)) here.
There was a problem hiding this comment.
This just makes the change in a string naming the test. Not the actual code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.