test: lossy gear #241
Draft
test: lossy gear #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gear efficiency example containing 2 inertias connected by an ideal gear Reference: https://github.com/modelica/ModelicaStandardLibrary/blob/master/Modelica/Mechanics/Rotational/Examples/LossyGearDemo1.mo
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
==========================================
- Coverage 16.02% 15.93% -0.09%
==========================================
Files 48 48
Lines 1629 1638 +9
==========================================
Hits 261 261
- Misses 1368 1377 +9 see 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
ven-k
reviewed
Nov 9, 2023
| @testset "lossy gear" begin | ||
| @mtkmodel LossyGear begin | ||
| @components begin | ||
| drive = Blocks.Sine(frequency=1, amplitude=10) |
There was a problem hiding this comment.
RN, this throws error. Splitting it to using Blocks: Sine and then drive = Sine(frequency=1, amplitude=10) should work now.
- Needs feat: support components with fully-qualified names with
@mtkmodelModelingToolkit.jl#2330 for Blocks.Sine to work inside the@mtkmodel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gear efficiency example containing 2 inertias connected by an ideal gear
Reference: https://github.com/modelica/ModelicaStandardLibrary/blob/master/Modelica/Mechanics/Rotational/Examples/LossyGearDemo1.mo