-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add cauer low pass analog filter example #240
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 16.02% 15.99% -0.03%
==========================================
Files 48 48
Lines 1629 1638 +9
==========================================
+ Hits 261 262 +1
- Misses 1368 1376 +8 see 3 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for this detailed tutorial :)
Would it be useful to add units to the capacitance and inductance parameters?
@ven-k has been adding units to components in
- Add units and missing descriptions to components #214
I'm not sure if adding units in this tutorial will work before that PR is merged?
|
||
```plaintext | ||
ERROR: Default algorithm choices require DifferentialEquations.jl. | ||
Please specify an algorithm (e.g., `solve(prob, Tsit5())` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can suggest using DifferentialEquations
and solve(prob)
instead of OrdinaryDiffEq?
(While keeping the note+url on where they can find all the solvers they can specify if they want to.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean for all the tutorials? Seems like a good idea to me. My understanding of the trade-off being OrdinaryDiffEq.jl
is more lightweight and therefore faster to load, but DifferentialEquations.jl
is more robust and offers conveniences to new users - which is useful for readers going through the tutorials.
Should I leave the note, and open an issue to switch over all tutorials and update docs/Project.toml
?
I'm keeping the Units PR open till upcoming breaking release; it would invalidate any model that use these along with unitless parameters. I can add units to this tutorial in that PR. |
Co-authored-by: Fredrik Bagge Carlson <[email protected]>
Co-authored-by: Fredrik Bagge Carlson <[email protected]>
I would be happy to add units after #214 is merged. Originally, I wrote the example to include units but then hit errors and had to remove them. |
No description provided.