Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SciMLBase.remake_initializeprob #2844

Closed

Conversation

AayushSabharwal
Copy link
Member

Close #2841

Requires SciML/SciMLBase.jl#731

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as draft July 22, 2024 07:11
@hersle
Copy link
Contributor

hersle commented Aug 13, 2024

Is this still under way?

@ChrisRackauckas
Copy link
Member

I believe so. @AayushSabharwal we should chat about the string of unmerged PRs from last week and what it will take to get them all merged, seems like there's a few that kind of got stuck.

@AayushSabharwal
Copy link
Member Author

This is waiting on the parameter initialization piece

@AayushSabharwal
Copy link
Member Author

Superseded by #2928

@AayushSabharwal AayushSabharwal deleted the as/remake-initprob branch August 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remake does not respect initial conditions of unknowns determined by initialization equations
3 participants