use a sym to ind dict #2206
Closed
use a sym to ind dict #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR*: julia> @benchmark ModelingToolkit.SymbolicIndexingInterface.state_sym_to_index($seir_model, $I)
BenchmarkTools.Trial: 8023 samples with 907 evaluations.
Range (min … max): 125.115 ns … 20.456 μs ┊ GC (min … max): 0.00% … 99.06%
Time (median): 130.808 ns ┊ GC (median): 0.00%
Time (mean ± σ): 136.253 ns ± 276.440 ns ┊ GC (mean ± σ): 3.14% ± 1.56%
▅▆█▆▄▁
▁▁▂▂▃▃▂▂▂▃▄▇██████▇▅▄▄▅▆█▇▇▇▇▆▆▅▄▄▃▃▃▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▂▁▁▁▁ ▃
125 ns Histogram: frequency by time 143 ns <
Memory estimate: 16 bytes, allocs estimate: 1.Master: julia> @benchmark ModelingToolkit.SymbolicIndexingInterface.state_sym_to_index($seir_model, $I)
BenchmarkTools.Trial: 10000 samples with 10 evaluations.
Range (min … max): 1.202 μs … 984.542 μs ┊ GC (min … max): 0.00% … 99.26%
Time (median): 1.297 μs ┊ GC (median): 0.00%
Time (mean ± σ): 1.758 μs ± 18.701 μs ┊ GC (mean ± σ): 24.67% ± 2.43%
▂▃▅▇█▇▆▅▄▃▂▁
▁▂▄▆█████████████▇▅▅▄▄▃▃▃▃▃▂▂▂▂▂▂▂▂▂▂▂▂▂▂▁▁▁▁▂▁▁▁▁▁▁▁▁▁▁▁▁▁ ▃
1.2 μs Histogram: frequency by time 1.69 μs <
Memory estimate: 2.42 KiB, allocs estimate: 19.*With these PRs, to speed up dict lookups: |
YingboMa
reviewed
Jul 10, 2023
src/systems/diffeqs/odesystem.jl
Outdated
| function ODESystem(tag, deqs, iv, dvs, ps, tspan, var_to_name, ctrls, observed, tgrad, | ||
| jac, ctrl_jac, Wfact, Wfact_t, name, systems, defaults, | ||
| torn_matching, connector_type, preface, cevents, | ||
| devents, metadata = nothing, gui_metadata = nothing, | ||
| tearing_state = nothing, | ||
| substitutions = nothing, complete = false, | ||
| discrete_subsystems = nothing, unknown_states = nothing; | ||
| discrete_subsystems = nothing, unknown_states = nothing, | ||
| sym_to_index = Dict{Num, Int}(); |
There was a problem hiding this comment.
Suggested change
| sym_to_index = Dict{Num, Int}(); | |
| sym_to_index = Dict{Any, Int}(); |
YingboMa
reviewed
Jul 10, 2023
src/systems/diffeqs/odesystem.jl
Outdated
| @@ -25,7 +25,7 @@ eqs = [D(x) ~ σ*(y-x), | |||
| struct ODESystem <: AbstractODESystem | |||
| """ | |||
| tag: a tag for the system. If two systems have the same tag, then they are | |||
| structurally identical. | |||
| structurally ide, sym_to_stringntical. | |||
|
@AayushSabharwal something of the sort is done at completion? I thought some indexing stuff was added |
|
Yeah indexes are cached in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.