Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted #6

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Sorted #6

merged 4 commits into from
Jan 25, 2024

Conversation

chriselrod
Copy link
Collaborator

No description provided.

@chriselrod
Copy link
Collaborator Author

I haven't looked at the bracketstrictlymonotonic yet; want me to SIMD it?

@ChrisRackauckas
Copy link
Member

Yes, if that's possible that would be awesome. Then it might make sense to make use of it instead of https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/src/dense/generic_dense.jl#L27-L55, which I forget what the origin of that search function was (@oscardssmith IIRC?)

@chriselrod
Copy link
Collaborator Author

chriselrod commented Jan 25, 2024

searchsortedfirst does pretty well compared to the method I added here. I haven't tested it that much yet, but bisection is pretty good, so the wins from mixing it with a linear scan might be small at best.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (47a7d57) 0.00% compared to head (591b366) 0.00%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/FindFirstFunctions.jl 0.00% 34 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main      #6   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         30      43   +13     
=====================================
- Misses        30      43   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

A SIMD bisection would be awesome for SimpleNonlinearSolve.jl I've considered it before, checking the j/(N+1) points instead of just 1/2 to subdivide quicker. Anyways, separate topic 😅

@ChrisRackauckas ChrisRackauckas merged commit fc6353b into main Jan 25, 2024
8 of 9 checks passed
@ChrisRackauckas ChrisRackauckas deleted the sorted branch January 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants