Improvements to graph plotting #1140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsas
requested changes
Dec 12, 2024
| @@ -14,13 +14,13 @@ Wrapper intended to allow plotting of multiple edges. This is needed in the foll | |||
| struct MultiGraphWrap{T} <: Graphs.AbstractGraph{T} | |||
| g::SimpleDiGraph{T} | |||
| multiedges::Vector{Graphs.SimpleEdge{T}} | |||
| edgeorder::Vector{Int64} | |||
| edgeorder::Vector{Int64} # sets the drawing order of the edges. Needed because multiedges need to be consecutive to be drawn properly. | |||
There was a problem hiding this comment.
Suggested change
| edgeorder::Vector{Int64} # sets the drawing order of the edges. Needed because multiedges need to be consecutive to be drawn properly. | |
| """sets the drawing order of the edges. Needed because multiedges need to be consecutive to be drawn properly.""" | |
| edgeorder::Vector{Int64} |
| # Return the multigraph and reaction order corresponding to the complex graph. The reaction order is the order of reactions(rn) that would match the edge order given by g.edgeorder. | ||
| function ComplexGraphWrap(rn::ReactionSystem) | ||
| img = incidencematgraph(rn); D = incidencemat(rn; sparse=true) | ||
| specs = species(rn); rxs = reactions(rn) |
There was a problem hiding this comment.
Suggested change
| specs = species(rn); rxs = reactions(rn) | |
| specs = species(rn) | |
| rxs = reactions(rn) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Stress()by default (if connected) to reduce edge crossings, adding support for kwargs, refactoring some code. Graph comparison below (after/before)