Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with more recent versions of mtk #1036

Closed
wants to merge 1 commit into from

Conversation

ctessum
Copy link

@ctessum ctessum commented Aug 30, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@isaacsas
Copy link
Member

isaacsas commented Aug 30, 2024

These aren't breaking releases, so why does this require updating the Project.toml MTK versions?

@isaacsas
Copy link
Member

isaacsas commented Aug 30, 2024

Note that we can't release a version with Symbolics 6 support till our CI is passing again. Hopefully the MTK unit PR I just submitted fixes things, but we need a new MTK release to test against.

@isaacsas
Copy link
Member

I'm going to close this. Once the new MTK release is available I will get #961 merged (assuming tests pass), and then make a new release. That should add support for newer MTK versions.

Thanks for the PR in either case though!

@isaacsas isaacsas closed this Aug 30, 2024
@isaacsas
Copy link
Member

Catalyst 14.4 should be released shortly and compatible with recent MTK versions.

@ctessum
Copy link
Author

ctessum commented Aug 31, 2024

Got it, thanks!

@ctessum ctessum deleted the patch-1 branch August 31, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants