Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove relative onyx imports from docs #2096

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

larsrickert
Copy link
Collaborator

We were currently using direct/relative imports for onyx components used in our VitePress docs. This required custom Vite/tsconfig options and might not be intuitive for new/External contributors taking a look at our codebase.

With our turbo repo setup, we can easily import directly from sit-onyx and turbo repo will make sure to build the components first. Like this our docs is just a regular consumer of the sit-onyx package, just like our playground and demo app.

@larsrickert larsrickert requested a review from a team as a code owner November 14, 2024 07:33
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 80433a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@larsrickert larsrickert changed the title refactor: remove relative onyx imports refactor: remove relative onyx imports from docs Nov 14, 2024
@larsrickert larsrickert enabled auto-merge (squash) November 14, 2024 07:33
@larsrickert larsrickert merged commit 6a1e781 into main Nov 14, 2024
19 checks passed
@larsrickert larsrickert deleted the refactor/docs-remove-direct-imports branch November 14, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants