Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OnyxTabs): support horizontal scrolling when overflowing #2089

Merged
merged 11 commits into from
Nov 15, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Nov 13, 2024

Relates to #2079

  • support horizontal scrolling when not all tabs fit into the available width
  • add property size to change the font style
  • add CSS variable --onyx-outline-width and use it in all components for consistency
  • make Storybook examples more realistic
  • fix vertical alignment of tab text if its not selected

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: e6b00fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Minor
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert marked this pull request as ready for review November 13, 2024 13:02
@larsrickert larsrickert requested a review from a team as a code owner November 13, 2024 13:02
@MajaZarkova MajaZarkova self-assigned this Nov 14, 2024
@larsrickert larsrickert enabled auto-merge (squash) November 15, 2024 09:14
@larsrickert larsrickert merged commit 3f55c48 into main Nov 15, 2024
19 checks passed
@larsrickert larsrickert deleted the feat/2018-tabs-overflow branch November 15, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants