Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@sit-onyx/shared): fix peerDependencies #2065

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

larsrickert
Copy link
Collaborator

Fix dependency warning with a too strict version scope for vue and sass-embedded when a package is installed that depends on @sit-onyx/shared as peerDependency (e.g. sit-onyx).

We must not use catalog: for peerDependencies, otherwise it will require the exact dependency version to be installed in the project. This leads to install warnings when e.g.sass-embedded version 1.80.5 is required but 1.80.6 is installed

Checklist

  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner November 11, 2024 12:55
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 5519bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sit-onyx/shared Patch
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Patch
sit-onyx Patch
@sit-onyx/storybook-utils Patch
@sit-onyx/nuxt Patch
@sit-onyx/vitepress-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert changed the title Fix/shared peer dependencies fix(@sit-onyx/shared): fix peerDependencies Nov 11, 2024
@larsrickert larsrickert enabled auto-merge (squash) November 11, 2024 13:37
@larsrickert larsrickert merged commit b6b4573 into main Nov 11, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/shared-peer-dependencies branch November 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants