Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement OnyxForm with disabled state injection #1902

Merged
merged 28 commits into from
Oct 2, 2024
Merged

Conversation

JoCa96
Copy link
Contributor

@JoCa96 JoCa96 commented Sep 30, 2024

Relates to #757

  • Implement OnyxForm component: Wrapper around Form, which allows setting the disabled state for all child form elements
  • Add E2E and unit tests
  • Add Storybook Documentation
  • Update all form elements to use injected disabled state

@JoCa96 JoCa96 requested a review from a team as a code owner September 30, 2024 16:38
Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: cee3b9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Minor
@sit-onyx/storybook-utils Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 changed the title feat: Implement OnyxForm feat: Implement OnyxForm with disabled state injection Oct 1, 2024
@larsrickert larsrickert self-assigned this Oct 1, 2024
larsrickert
larsrickert previously approved these changes Oct 1, 2024
@JoCa96 JoCa96 dismissed larsrickert’s stale review October 1, 2024 14:57

The merge-base changed after approval.

@JoCa96 JoCa96 enabled auto-merge (squash) October 2, 2024 06:40
@JoCa96 JoCa96 merged commit 5d8349c into main Oct 2, 2024
19 checks passed
@JoCa96 JoCa96 deleted the 757-onyx-form branch October 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants